Conversation
Feature/jax merge 2
Feature/remove convolver
Feature/jax unit tests
Feature/jax wrapper point solver
Feature/jax linear light
rhayes777
approved these changes
Jun 16, 2025
Collaborator
rhayes777
left a comment
rhayes777
left a comment
There was a problem hiding this comment.
Nice so it works end to end now?
Collaborator
Author
|
The grad function on the image-plane chi squareds gives all zeros, so I think there may still be a bug, but the jit compiles and gives a likelihood corrctly. For a source plane chi squared the grad looks correct. Need to dig deeper before deciding if its a bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full support for JAX point source likelihood functions, including updates to
OperateDeflectionsclass.